Skip to content

Conversation

@Lee-W
Copy link
Member

@Lee-W Lee-W commented Jan 30, 2025

Description

  • docs(hooks): fix missing link
  • style(hooks): improve type annotation

Checklist

  • Add test cases to all the changes you introduce
  • Run ./scripts/format and ./scripts/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Expected behavior

Everything should still be the same

Steps to Test This Pull Request

None

Additional context

@codecov
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.58%. Comparing base (120d514) to head (79065bd).
Report is 555 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1345      +/-   ##
==========================================
+ Coverage   97.33%   97.58%   +0.25%     
==========================================
  Files          42       55      +13     
  Lines        2104     2614     +510     
==========================================
+ Hits         2048     2551     +503     
- Misses         56       63       +7     
Flag Coverage Δ
unittests 97.58% <ø> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@noirbizarre noirbizarre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

Note for later:

  • we should also provide them as pre-commit hook
  • maybe we should have a cz hook install or something like that to avoid the manual fetch with curl

@Lee-W Lee-W added pr-status: ready-to-merge almost ready to merge. just keep it for a few days for others to check and removed pr-status: wait-for-review labels Feb 8, 2025
@Lee-W
Copy link
Member Author

Lee-W commented Feb 8, 2025

👍🏼

Note for later:

* we should also provide them as pre-commit hook

* maybe we should have a `cz hook install` or something like that to avoid the manual fetch with curl

Yep, I was thinking about that as well (but not yet have time 🥲). added an issue #1355 to track this

@Lee-W Lee-W merged commit b4dc832 into master Feb 8, 2025
18 checks passed
@Lee-W Lee-W deleted the improve-hooks-type branch February 8, 2025 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-status: ready-to-merge almost ready to merge. just keep it for a few days for others to check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants